refactor(proto): remove unused proto discover definition - #7014

[SHOULD] Please record the pre-change serialization comparison required by #7013, including the commands, fixtures and results, or add fixed regression fixtures for Endpoint, HelloMessage and BackupMessage. The current PR does not document this comparison.

[DISCUSS] Please reconcile #7013's conditional deprecation requirement with the clarification in #6921 that these are unsupported legacy types. Record the agreed classification and describe the generated-type removal and expected descriptor change in this PR's compatibility notes.

Endpoint and BackupMessage retain exactly the same fields and options, and HelloMessage is also unchanged. Given this scope, I don’t think additional serialization tests are necessary for this cleanup.

The four removed legacy message types have been unused by java-tron for years and are not supported external APIs, as clarified in #6921. Their removal therefore does not require a deprecation cycle. The removal of the generated types and the corresponding descriptor changes are intentional and can be documented in the PR’s compatibility notes.

Thanks. On the serialization comparison: agreed, no additional permanent regression tests are needed for this cleanup. For the record, I ran the comparison against the merge base 6d5adc4: buf breaking reports only the four removed messages under FILE rules and nothing under WIRE, and protoc --encode produces identical bytes before and after for Endpoint, HelloMessage and BackupMessage, including IPv6, default-value and negative priority cases. This addresses the pre-change serialization comparison requested in #7013. The other two items were also checked on 7875e68 (4b63f5f only changes documentation): protobuf sources regenerated and compiled in a clean worktree, and the related handshake, backup and p2p discovery tests passed (44/44).

[SHOULD] On the classification: agreed. Please add the compatibility note to the PR description before merge, and update the last paragraph of #7013 to match. Suggested text:

Compatibility: The retained messages preserve their existing wire encoding. No runtime networking or consensus changes are introduced. The generated Java types org.tron.protos.Discover.PingMessage, PongMessage, FindNeighbours and Neighbours are removed, and the core/Discover.proto descriptor changes accordingly (BackupMessage moves from message index 5 to 1). Per #6921 these are unsupported legacy types, so no deprecation cycle is required. The active UDP discovery definitions are in p2p/src/main/proto/Discover.proto (org.tron.p2p.protos.Discover), which uses a different Java package and protobuf namespace, so they are not drop-in replacements.

[NIT] Please correct "defintion" to "definition" in the PR title.

@waynercheung I have update the PR description and PR title, thanks for your suggestion.

Thanks for the updates. The compatibility note and title look good, and my earlier verification still applies since the code is unchanged (4b63f5f). LGTM.

[NIT] The last paragraph of #7013 still describes a conditional deprecation cycle; please update it to match the compatibility note here.

Thanks, I have update the of last paragraph of issue #7013.